----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63925/#review191394 -----------------------------------------------------------
Fix it, then Ship it! please fix the minor comment and push the changes. Please wait till the upstream tests are green before submitting the changes. sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java Lines 162 (patched) <https://reviews.apache.org/r/63925/#comment269193> "Finishedd", plesae fix the typo. Logs at line 162 and 163 be merged to one log statement. - kalyan kumar kalvagadda On Nov. 17, 2017, 9:04 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63925/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2017, 9:04 p.m.) > > > Review request for sentry. > > > Bugs: sentry-1640 > https://issues.apache.org/jira/browse/sentry-1640 > > > Repository: sentry > > > Description > ------- > > This patch implements a HMS post-event listener that is executed after an HMS > operation has succeeded and it waits for Sentry to sync the notification > generated by the HMS operation. This is the client side implementation for > SENTRY-1600 and SENTRY-1601 > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java > PRE-CREATION > > sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/metastore/TestSentrySyncHMSNotificationsPostEventListener.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java > 61833fcf2d387875dc5c49ab12d08a321ffaeed8 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java > 7ada1380aa390e282cc28221150f67077ccf1cfa > > > Diff: https://reviews.apache.org/r/63925/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >
