----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63993/ -----------------------------------------------------------
(Updated Nov. 21, 2017, 6:34 p.m.) Review request for sentry, kalyan kumar kalvagadda, Na Li, Sergio Pena, and Vadim Spector. Changes ------- Accounted for Lina and Kalyan's comments Repository: sentry Description ------- AUTHZ_PATHS_SNAPSHOT_ID is only populated when a full HMS snapshot is persisted. When initially HDFS Sync is disabled, we will create a full snapshot but never persist it, and at the same time populate SENTRY_HMS_NOTIFICATION_ID table. Later when HDFS sync is enabled, a full snapshot will not occur unless until HMS and Sentry are out of sync. This will result in ACL's not being applied unless until HMS and Sentry are out of sync, since we only send NN snapshots if AUTHZ_PATHS_SNAPSHOT_ID has values greater than 0 We should create a full snapshot if hdfsSync is enabled, and AUTHZ_PATHS_SNAPSHOT_ID is empty Diffs (updated) ----- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 4dc2bf6d1 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java c4cc91806 sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java bbcf09382 Diff: https://reviews.apache.org/r/63993/diff/2/ Changes: https://reviews.apache.org/r/63993/diff/1-2/ Testing ------- mvn -f sentry-provider/sentry-provider-db/pom.xml test Thanks, Arjun Mishra
