-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63596/
-----------------------------------------------------------

(Updated Nov. 29, 2017, 5:20 p.m.)


Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, Na Li, 
Sergio Pena, and Vadim Spector.


Changes
-------

Updated patch based on Sergio's feedback


Repository: sentry


Description
-------

The old retrieveFullPathsImage() method in SentryStore is no longer used by 
actual code (retrieveFullPathsImageUpdate(final String[] prefixes) is used 
instead. It was preserved because it is used by test which now doesn't make 
much sense.


Diffs (updated)
-----

  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
 f32a745ed 
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
 c1471d118 
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java
 eccb40fb6 


Diff: https://reviews.apache.org/r/63596/diff/3/

Changes: https://reviews.apache.org/r/63596/diff/2-3/


Testing
-------

mvn -f sentry-provider/sentry-provider-db/pom.xml test -Dtest=TestSentryStore
mvn -f sentry-hdfs/sentry-hdfs-service/pom.xml test 
-Dtest=TestSentryHDFSServiceProcessor
mvn -f sentry-hdfs/sentry-hdfs-service/pom.xml test 
-Dtest=TestImageRetriever.java


Thanks,

Arjun Mishra

Reply via email to