> On Dec. 1, 2017, 10:28 p.m., Alexander Kolbasov wrote: > > LICENSE.txt > > Line 214 (original) > > <https://reviews.apache.org/r/64241/diff/7/?file=1906151#file1906151line214> > > > > Should theLICENSE.txt include copyrights as well or not? Looks like you > > are removing some copyrights.
previously we has some licenses embedded here. Now, we are adding pointers to the licences. "For details, see the associated license in sentry-dist/src/main/resources/licenses/BSD_License.txt" > On Dec. 1, 2017, 10:28 p.m., Alexander Kolbasov wrote: > > README_license.txt > > Lines 11 (patched) > > <https://reviews.apache.org/r/64241/diff/7/?file=1906152#file1906152line11> > > > > Does it run during every build or it should be manually invoked? It run's on every build in package phase of mvn > On Dec. 1, 2017, 10:28 p.m., Alexander Kolbasov wrote: > > README_license.txt > > Lines 34 (patched) > > <https://reviews.apache.org/r/64241/diff/7/?file=1906152#file1906152line34> > > > > Is there anything that checks correctness of pointers? What would > > happen if release manager forgets to add the file? I will be adding this in the release process in the Wiki. - kalyan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64241/#review192558 ----------------------------------------------------------- On Dec. 1, 2017, 11:12 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64241/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2017, 11:12 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, Colm O > hEigeartaigh, and Sergio Pena. > > > Bugs: SENTRY-2081 > https://issues.apache.org/jira/browse/SENTRY-2081 > > > Repository: sentry > > > Description > ------- > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. > > > Diffs > ----- > > LICENSE.txt b794ae6604774186020a1cf3dde922e92da57276 > README_license.txt PRE-CREATION > pom.xml eec185bc6409e5cebee12f3a0e4ca17c843cd631 > sentry-dist/pom.xml 4c69535660b132943c7cdc2419fff140a0909a48 > sentry-dist/src/license/THIRD-PARTY.ftl PRE-CREATION > sentry-dist/src/license/THIRD-PARTY.properties PRE-CREATION > sentry-dist/src/license/override-THIRD-PARTY.properties PRE-CREATION > sentry-dist/src/main/assembly/bin.xml > 5727fc964bc139a5bd5490132efad13db6cbcf44 > sentry-dist/src/main/resources/licences/BSD_2-clause.txt PRE-CREATION > sentry-dist/src/main/resources/licences/BSD_License.txt PRE-CREATION > sentry-dist/src/main/resources/licences/CDDL_1_0.txt PRE-CREATION > sentry-dist/src/main/resources/licences/CDDL_1_1.txt PRE-CREATION > sentry-dist/src/main/resources/licences/CDDL_2.txt PRE-CREATION > > sentry-dist/src/main/resources/licences/Eclipse_Public_License_-_Version_1_0.txt > PRE-CREATION > sentry-dist/src/main/resources/licences/MIT_License.txt PRE-CREATION > > sentry-dist/src/main/resources/licences/Mozilla_Public_License_Version_1_1.txt > PRE-CREATION > sentry-dist/src/main/resources/licences/The_BSD_3-Clause_License.txt > PRE-CREATION > > > Diff: https://reviews.apache.org/r/64241/diff/8/ > > > Testing > ------- > > Made sure that LICENSE.txt file generated in sentry-dist/target directory has > the license informaion of all the jars that sentry is distributing. > > > Thanks, > > kalyan kumar kalvagadda > >
