----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63958/ -----------------------------------------------------------
(Updated Dec. 5, 2017, 9:09 p.m.) Review request for sentry, Na Li and Sergio Pena. Changes ------- adddresed review comments. Bugs: SENTRY-2034 https://issues.apache.org/jira/browse/SENTRY-2034 Repository: sentry Description ------- Currently, there are no e2e tests that test the functionality of pulling the notifications from HMS and processing them. Which include updating the update the permissions based on the HMS updates. Diffs (updated) ----- sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java 21383046f8a5b7386cfe9f6f62c0119542a73382 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java PRE-CREATION sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingBase.java PRE-CREATION sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java PRE-CREATION sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java PRE-CREATION sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java PRE-CREATION sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java 33ace57134b20189aa10bee48f6aae765a1a1830 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java c8eef09ed61e11583838a3dfd3117a9478df23ba sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java 645fc354c3b4e5b21456ee9a471253ffa4624f17 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java a911e2f50f63db6a99996ce44a74ad6bcc2a82b0 Diff: https://reviews.apache.org/r/63958/diff/3/ Changes: https://reviews.apache.org/r/63958/diff/2-3/ Testing ------- Made sure that new tests added and all the older tests pass. Thanks, kalyan kumar kalvagadda