> On Dec. 15, 2017, 7:51 p.m., Alexander Kolbasov wrote: > > sentry-command-line-tools/pom.xml > > Lines 60 (patched) > > <https://reviews.apache.org/r/64259/diff/2/?file=1912667#file1912667line60> > > > > I'm curios, what uses this?
I don't think we use it here, so I will remove it > On Dec. 15, 2017, 7:51 p.m., Alexander Kolbasov wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java > > Line 45 (original), 49 (patched) > > <https://reviews.apache.org/r/64259/diff/2/?file=1912668#file1912668line49> > > > > Do you actually use these classes now? I think you only check for valid > > command string which you do in the switch() statement below, so I guess > > this can be removed now. I think it probably still going to be needed since on line 67: options.addOption(null, COMMAND, true, "Command to run. Options: " + COMMANDS.keySet()); what do you think? - Xinran ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64259/#review193957 ----------------------------------------------------------- On Dec. 11, 2017, 8:03 p.m., Xinran Tinney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64259/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2017, 8:03 p.m.) > > > Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar > kalvagadda, Na Li, and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > TheSentryMain class currently works by mapping the command name to a Java > class that is then dynamically loaded: > String commandName = commandLine.getOptionValue(COMMAND); > String commandClazz = COMMANDS.get(commandName); > Object command; > try { > command = Class.forName(commandClazz.trim()).newInstance(); > } catch (Exception e) { > String msg = "Could not create instance of " + commandClazz + " for > command " + commandName; > throw new IllegalStateException(msg, e); > } > if (!(command instanceof Command)) { > String msg = "Command " + command.getClass().getName() + " is not an > instance of " > + Command.class.getName(); > throw new IllegalStateException(msg); > } > ((Command)command).run(commandLine.getArgs()); > } > This ia too complicated and causes subtle problems at runtime. Instead it > should just create a new instance of appropriate class and call it directly. > > > Diffs > ----- > > bin/config_tool 4da85673 > bin/run_sentry.sh d58d5e5c > bin/sentry 54e545aa > pom.xml dd408d85 > sentry-command-line-tools/pom.xml PRE-CREATION > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java > 3a981b2a > > > Diff: https://reviews.apache.org/r/64259/diff/2/ > > > Testing > ------- > > mvn clean install, on cloudcat and all SUCCESS > > > Thanks, > > Xinran Tinney > >
