> On Jan. 2, 2018, 5:04 p.m., Steve Moist wrote: > > pom.xml > > Lines 117 (patched) > > <https://reviews.apache.org/r/64890/diff/1/?file=1929483#file1929483line117> > > > > Looks like 4.2.1 is the latest version, any reason why we're not using > > it? > > Xinran Tinney wrote: > I was following an example that was 4.2.0, let me test 4.2.1 and if it > works fine, I will switch.
I found that even without adding dependency of clover in the pom, it works as long as plugin is mentioned in maven's setting.xml. Should I delete this code review? - Xinran ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64890/#review194640 ----------------------------------------------------------- On Jan. 2, 2018, 4:43 p.m., Xinran Tinney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64890/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2018, 4:43 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > add clover plugin to maven to get code coverage report > > > Diffs > ----- > > pom.xml c797181c > > > Diff: https://reviews.apache.org/r/64890/diff/1/ > > > Testing > ------- > > mvn clean install on testing cluster and all the tests past. > The steps for generating a clover report is as folllows: (Since clover has > become an opensource now, the one used is openclover) > 1. Put > <pluginGroups> > <pluginGroup>org.openclover</pluginGroup> > </pluginGroups> > In maven/conf/settings.xml > 2. It is required to first create a Clover database, run > mvn clover:instrument > 3. To generate report, run > mvn clover:clover > The report is in each module's folder e.g., > .../sentry/sentry-provider/sentry-provider-db/target/site/clover/clover.xml' > > > Thanks, > > Xinran Tinney > >
