-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64960/
-----------------------------------------------------------
(Updated Jan. 8, 2018, 3:26 p.m.)
Review request for sentry, Alexander Kolbasov, Arjun Mishra, Na Li, Sergio
Pena, and Vadim Spector.
Changes
-------
Addressed comments from Lina.
Bugs: SENTRY-2113
https://issues.apache.org/jira/browse/SENTRY-2113
Repository: sentry
Description
-------
Here is the description of code changes done
1. Made code changes to sql scripts to have notificaiton has in
SENTRY_HMS_NOTIFICATION_ID table with unique index.
2. Made JDO changes to have notification has in MSentryHmsNotification
3. Added additional logging which will be helpfull in debugging.
4. Code changes to persist notification has along with event-id in
SENTRY_HMS_NOTIFICATION_ID table.
5. Lookup MSentryHmsNotification to know if the notification is processed
instead of using MSentryPathChange.
6. Avoid looking for MSentryHmsNotification to descide if snapshot is needed.
As this is not correct. If there are no notifications after a snapshot is taken
there will be full snpashots taken again and again. Instead it is changes to
use Path Mapping information.
7. Fixed the tests
Diffs (updated)
-----
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/UniquePathsUpdate.java
38b4e2a
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryHmsNotification.java
34180e7
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo
d883c51
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/DeltaTransactionBlock.java
849e5f8
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
6c4631f
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreSchemaInfo.java
f1a5b10
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SentrySchemaTool.java
d75e24b
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
aa1b6a3
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java
097aa62
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/NotificationProcessor.java
d09da5f
sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2113.derby.sql
PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2113.mysql.sql
PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2113.oracle.sql
PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2113.postgres.sql
PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.1.0.sql
PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.1.0.sql
PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.1.0.sql
PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.1.0.sql
PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.1.0.sql
PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-2.0.0-to-2.1.0.sql
PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-2.0.0-to-2.1.0.sql
PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-2.0.0-to-2.1.0.sql
PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-2.0.0-to-2.1.0.sql
PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-2.0.0-to-2.1.0.sql
PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.db2
5ae9349
sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.derby
770e1b5
sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.mysql
770e1b5
sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.oracle
770e1b5
sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.postgres
770e1b5
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
b410027
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java
edde886
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestNotificationProcessor.java
964a56c
Diff: https://reviews.apache.org/r/64960/diff/2/
Changes: https://reviews.apache.org/r/64960/diff/1-2/
Testing
-------
Made sure all the tests are passing.
Thanks,
kalyan kumar kalvagadda
