----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65046/ -----------------------------------------------------------
(Updated Jan. 11, 2018, 10:14 p.m.) Review request for sentry, Alexander Kolbasov, Arjun Mishra, Colm O hEigeartaigh, kalyan kumar kalvagadda, Na Li, and Sergio Pena. Changes ------- Added all the actual imports instead of using .*; Repository: sentry Description ------- We have several important classes - e.g. HMSFollower, NotificationProcessor, CounterWait, LeaderStatusMonitor in the sentry.service.thrift package which is weird - they should be in provider.db.service.persistent instead. Diffs (updated) ----- sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java eee44892 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 6c4631fa sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/CounterWait.java 558e6953 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSClient.java 86ff47e0 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java aa1b6a31 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java 097aa629 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveSimpleConnectionFactory.java 77634cf2 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java 8e80d558 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/NotificationProcessor.java d09da5fb sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java 7e774b4a sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java 43535a7b sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollowerSentryStoreIntegration.java 501898bc sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestCounterWait.java 090999a0 sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java edde886a sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestLeaderStatusMonitor.java 72d52de1 sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestNotificationProcessor.java 964a56cd Diff: https://reviews.apache.org/r/65046/diff/4/ Changes: https://reviews.apache.org/r/65046/diff/3-4/ Testing ------- 'mvn clean install' on testing cluster. Thanks, Xinran Tinney
