----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64452/ -----------------------------------------------------------
(Updated Jan. 22, 2018, 9:16 p.m.) Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, Sergio Pena, and Vadim Spector. Repository: sentry Description ------- Update the code to make sure user without group but with role has proper access. test case is added for the scenario that user has no group but with desired role. test case is added for the scenario that user has no group and no privilege to allow the access Diffs (updated) ----- sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/HiveAuthzBindingHookBaseV2.java 5a21dd3 sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBindingHookBase.java 447deaf sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ResourceAuthorizationProvider.java a9b98f3 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java edea5b6 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestGrantUserToRole.java 5364937 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUserManagement.java fd8ec56 Diff: https://reviews.apache.org/r/64452/diff/3/ Changes: https://reviews.apache.org/r/64452/diff/2-3/ Testing ------- unit tests Thanks, Na Li