-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65268/
-----------------------------------------------------------
(Updated Feb. 12, 2018, 11:50 p.m.)
Review request for sentry, Arjun Mishra, Na Li, Sergio Pena, and Vadim Spector.
Changes
-------
Made code changes to address comments from sasha and xinran.
Bugs: SENTRY-1904
https://issues.apache.org/jira/browse/SENTRY-1904
Repository: sentry
Description
-------
The TransactionManager uses exponential backoff strategy for transaction
retries. This may cause some transactions to be delayed by a very long time. We
should also have a constraint on the max time for a transaction so that we do
not retry for too long.
New patch that is attached adds upper bounds on below
1.Interval between the retry attempts which increases exponentially.
2.Total time a transaction could spend in retries.
3.Removed retry based on count.
With out these limits we would not have a control on how long a transaction
could be be active.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/TransactionManager.java
f4ff962a67f8a5c23cc5c8daa7bcb861d2e6b6a5
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java
7e02874b4be6a7109108809b1f404fe971b7b8e2
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollowerSentryStoreIntegration.java
91c90f9d302f4feb3a8b3d06541f43541c87bf0f
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
b4100278392986c161625a366212c6fef66ec0a9
Diff: https://reviews.apache.org/r/65268/diff/8/
Changes: https://reviews.apache.org/r/65268/diff/7-8/
Testing
-------
Made sure all the tests pass.
Thanks,
kalyan kumar kalvagadda
