----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65639/#review197449 -----------------------------------------------------------
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java Line 206 (original), 206 (patched) <https://reviews.apache.org/r/65639/#comment277611> It is not clear why if it is group, you throw exception. if ((type != PrincipalType.Role) && (type != PrincipalType.User)) would be more clear what is supported. It also works if more type is added into PrincipalType sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java Line 203 (original), 208 (patched) <https://reviews.apache.org/r/65639/#comment277612> same here - Na Li On Feb. 13, 2018, 8:21 p.m., Steve Moist wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65639/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2018, 8:21 p.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Enabled use of show grant on table and show grant on database for the current > user. > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java > 1e520c0b > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > 14a96191 > > sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java > c75f57d6 > > > Diff: https://reviews.apache.org/r/65639/diff/1/ > > > Testing > ------- > > Added unit tests, mvn clean package on sentry-binding/sentry-binding-hive > > > Thanks, > > Steve Moist > >
