-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65816/
-----------------------------------------------------------

(Updated Feb. 28, 2018, 12:09 p.m.)


Review request for sentry.


Bugs: SENTRY-2145
    https://issues.apache.org/jira/browse/SENTRY-2145


Repository: sentry


Description
-------

This task is to implement some misc code cleanups:

a) Use StringBuilder instead of looping and using "+" with a String

b) Use EntrySet instead of KeySet when the value is also required

c) Make sure constants are static final.


Diffs (updated)
-----

  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryValidator.java
 319a1be5 
  
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java
 908c80f1 
  
sentry-core/sentry-core-model-solr/src/main/java/org/apache/sentry/core/model/solr/AdminOperation.java
 c054b7dc 


Diff: https://reviews.apache.org/r/65816/diff/2/

Changes: https://reviews.apache.org/r/65816/diff/1-2/


Testing
-------


Thanks,

Colm O hEigeartaigh

Reply via email to