----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66146/#review199566 -----------------------------------------------------------
Lina, Code looks good but we need to run some performance tests with some huge data to actually see the results. Simple unit test may not be good enough. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 2616 (patched) <https://reviews.apache.org/r/66146/#comment279867> Isn't using fp.setGroup(FetchPlan.DEFAULT) a better option? - kalyan kumar kalvagadda On March 19, 2018, 6:43 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66146/ > ----------------------------------------------------------- > > (Updated March 19, 2018, 6:43 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > Configure DataNucleus to fetch MPath in bulk to improve performance > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > d883c51 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 4521ad4 > > > Diff: https://reviews.apache.org/r/66146/diff/1/ > > > Testing > ------- > > Run unti tests. > Check log message that veries that the query for MPath is issued in bullk. > > > Thanks, > > Na Li > >
