> On March 14, 2018, 3:56 p.m., Na Li wrote: > > what jira will you add code to handle db events processing relate to owner > > privileges? > > kalyan kumar kalvagadda wrote: > SENTRY-2153 will add code to update the cache. > There should another jira created to add inplcit privileges. > > Na Li wrote: > Is there a jira to add owner privileges when owner privileges change in > alter database event? > Is there a jira to get current owner privileges of databases. > > kalyan kumar kalvagadda wrote: > There is an issue with alter database event. hive 2.3.2 doesn't support > alter database event. > I have created to SENTRY-2182 to extend the SentryJSONMessageFactory but > it can not be done until we have this functionality in hive version that > sentry uses. > > Can you elaborte, "Is there a jira to get current owner privileges of > databases.". In either way this it out of scope of this jira.
I meant when sentry server starts and is leader, it should get current owner privileges of existing databases. Just processing events for creating database and alter database is not enough. SENTRY-2153 includes this. It originally includes the effort for this jira and SENTRY-2182. Can you update the description for sentry-2153 since you splited the effort into 3 jira? - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66066/#review199173 ----------------------------------------------------------- On March 14, 2018, 2:43 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66066/ > ----------------------------------------------------------- > > (Updated March 14, 2018, 2:43 p.m.) > > > Review request for sentry, Na Li and Sergio Pena. > > > Bugs: SENTRY-2181 > https://issues.apache.org/jira/browse/SENTRY-2181 > > > Repository: sentry > > > Description > ------- > > This patch makes changes so that owner privileges are updated in the > SentryJSONCreateDatabaseMessage on receiving create database event. > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONCreateDatabaseMessage.java > a519fd7bad2b99ae57e46afdccdf325a37def0cd > > sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageFactory.java > 0d0c73fa989dab32820cef52281e261f19fc54e8 > > sentry-binding/sentry-binding-hive-follower/src/test/java/org/apache/sentry/binding/metastore/messaging/json/TestSentryJSONCreateDatabaseMessage.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestFullUpdateModifier.java > c6be80d71981cf75d8e76a063b6cda0d75c65fb4 > > > Diff: https://reviews.apache.org/r/66066/diff/1/ > > > Testing > ------- > > added new test and also made made sure that all the tests passed. > > > Thanks, > > kalyan kumar kalvagadda > >
