Hey all, I’ve started writing some skeleton apis for ABAC.  In the process, 
I’ve had to regenerate the Thrift api.  Anytime that happens, it regenerates 
all the files and gives it a new timestamp.  So when I look in git, it shows 
75+ files have changed in addition to my new set of apis.  I then have to 
manually roll back each file.  As a development process this is terrible.  So…

1) Is there any reason why we need thrift apis in source control?
2) Anyone object to using a newer maven plugin to generate the thrift apis on 
build time?
2a) This requires all developers to install thrift 0.9.3.   I personally don’t 
see a problem as I have to have protobuf installed to compile hadoop.  (Most 
sentry devs probably already have it anyway)
2b) This will impact build systems to have thrift compiler installed.
3) This prevents the above headache and makes it far simpler and faster to 
develop for Sentry.  And makes for happier devs.
4) Dumping generated code into target/generated-sources is a standard 
development practice when working against a known schema.

Reply via email to