----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66336/#review200140 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/CounterWait.java Lines 191 (patched) <https://reviews.apache.org/r/66336/#comment280792> Here and beow - te COunterWait class is generic. So I don't think that HMS Thread should be mentioned here. Here, for example, you are actually saying that you immediately wake up eventId. So, may be "returning from wait for {}" ? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/CounterWait.java Lines 204 (patched) <https://reviews.apache.org/r/66336/#comment280793> See comment above. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/CounterWait.java Line 213 (original), 218 (patched) <https://reviews.apache.org/r/66336/#comment280794> un-blocked is a single word. Why not just "returning from wait for {}"? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/CounterWait.java Line 243 (original), 249 (patched) <https://reviews.apache.org/r/66336/#comment280795> What's wrong with the original message? - Alexander Kolbasov On March 28, 2018, 4:14 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66336/ > ----------------------------------------------------------- > > (Updated March 28, 2018, 4:14 p.m.) > > > Review request for sentry and Na Li. > > > Bugs: SENTRY-2190 > https://issues.apache.org/jira/browse/SENTRY-2190 > > > Repository: sentry > > > Description > ------- > > Debug logging in CounterWait is not good enough to actually an issue around > this area. It's a good idea to extend the current logging. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/CounterWait.java > d8c82970b56b1599a07f0e26edab8ed3d59b9948 > > > Diff: https://reviews.apache.org/r/66336/diff/1/ > > > Testing > ------- > > > Thanks, > > kalyan kumar kalvagadda > >
