-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66360/
-----------------------------------------------------------

Review request for sentry, Alexander Kolbasov, Na Li, Steve Moist, and Sergio 
Pena.


Bugs: SENTRY-2192
    https://issues.apache.org/jira/browse/SENTRY-2192


Repository: sentry


Description
-------

With the current thrift options used, @Generated annotation adds date which 
kind of updates all the thrift generated files when --thriftif option used.

When someone makes some changes to any of the thrift definitions and tries to 
generate the source all the auto generated files get updated.

This can be avoided by suppressing date in the @generated annotation.


Diffs
-----

  sentry-hdfs/sentry-hdfs-common/pom.xml 
5c6c96c46ee384ba5981611333741fde3bd59e10 
  
sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/SentryHDFSService.java
 ac1fa6af17239e23557614e7149c7cc911e28e12 
  
sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TAuthzUpdateRequest.java
 62fd0bb2426db427241a5f805c9e250b306b4947 
  
sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TAuthzUpdateResponse.java
 68aec801ae7f38f8cbbe8549f5d9df79b609b114 
  
sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathChanges.java
 8d3297ffe6f2de4dc3dc82f82a70b5ad2a235911 
  
sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathEntry.java
 210d2191c38603d4a951a590eee85c8fccdde124 
  
sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathsDump.java
 df5b7b10656102c6471885cfea73b0ed8dd67dd7 
  
sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathsUpdate.java
 9fd3924f138696707df4ab1bb5c994005b9bd1f4 
  
sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPermissionsUpdate.java
 e8c09322ac6f8b8210bc4dd8869ad3b0353b63d9 
  
sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPrivilegeChanges.java
 0472f33ec49652ef402bcb332321fb2803b923d9 
  
sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TRoleChanges.java
 1a502080896b2b85e9bf6ae4780b4a2db35473f7 
  sentry-provider/sentry-provider-db/pom.xml 
4751549bcc40d60ca8f5400dd371761bc6fbf2d5 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyService.java
 ae4d8888b6a06c72a93e62bc5a3c2a17776bcb7d 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleAddGroupsRequest.java
 0b62dae0588859bceea54b8f4b49689561a7a4f9 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleAddGroupsResponse.java
 29e5baf8d3ecd67ae655f513eaba5a1a2bc14b9a 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleDeleteGroupsRequest.java
 42293b7bbda879d87f69721cfc3f4fd533055ae2 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleDeleteGroupsResponse.java
 a3a660cc9d53411588c5a681b84a75a35ebc3f96 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleGrantPrivilegeRequest.java
 49cfe4b0057721839c442353b6441013d5d6438c 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleGrantPrivilegeResponse.java
 6890337d6262500283086abf54e19ff1450796f8 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleRevokePrivilegeRequest.java
 91793fee0f3a96a2fdec0cfecac325c65c08c999 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleRevokePrivilegeResponse.java
 bd7127bac0d9b03b6fef690c11fbb924029017d1 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAuthorizable.java
 6ab06f70dabcdf20140e2c1fdd3801886c4e924a 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TCreateSentryRoleRequest.java
 786c6437bd41d4a16013eade8b1c52e8943f92b9 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TCreateSentryRoleResponse.java
 b2c14a03bce5a32849d9b68a970d6698a958f44d 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TDropPrivilegesRequest.java
 6258969f94bc1397144cf89c1b78b89c466668ea 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TDropPrivilegesResponse.java
 8d0ecaf7589581b6981547acbae4e20debe70efc 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TDropSentryRoleRequest.java
 1eaf496d730cc390faf59528b8445a8d5ff60dc1 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TDropSentryRoleResponse.java
 61f7c4d2dcceb45f5c2fa4439d6c0d4eb9d66e8b 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryPrivilegesByAuthRequest.java
 ff51de7d0ce643fe8f9f22f63ce269309fe3c12b 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryPrivilegesByAuthResponse.java
 dc2ea5949e5e5911d42080b223bcb246eee337b4 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryPrivilegesForProviderRequest.java
 5ce1c0c1a5586c35b45cf3b479a3c436d005563d 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryPrivilegesForProviderResponse.java
 1421f8fa7be33d139f4823fc16ec250f6caa20be 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryPrivilegesRequest.java
 46e51c884298893eaa00a59c3222fcb7c4497f4b 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryPrivilegesResponse.java
 3081a88d2c03a42d76b7ebfa28b1f33f5137acc3 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryRolesRequest.java
 d158e693b4b9fd283d234b174572b55397783868 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryRolesResponse.java
 95d98f48a8d3ad5e9684c9279ded882656643abe 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TRenamePrivilegesRequest.java
 c80ebbd47ea2d5fd954652e3cea39d0d7fbc638e 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TRenamePrivilegesResponse.java
 d6316264e769d62f94fd225f6640346e0ccc7c1b 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TSentryActiveRoleSet.java
 4e1da06df5aa6c68ccd43320a032875a164cbb4e 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TSentryPrivilege.java
 e4ab0cd6656ec9bb8b9b93d1c8e7b31b464d00d8 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TSentryPrivilegeMap.java
 847709524fa9e645dcbc9b535b18ae60611f2ac1 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TSentryRole.java
 950abc0e9f3413e848daad0e5050002d1bd3c639 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/SentryPolicyService.java
 f7cefa522e61d02adc4519980fd6e36b590aa245 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleAddGroupsRequest.java
 a3412f2a104132eb2fd88f1a2671abb5c6dbcde7 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleAddGroupsResponse.java
 e7f1778f947f6e3ab26e9f3a9200b2ea9427eae2 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleAddUsersRequest.java
 3a2ed35d2ab13272c7d0f7875d16f7a16bd88314 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleAddUsersResponse.java
 ada09528f836fe1e43645dcf2e244f71dc5888c0 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleDeleteGroupsRequest.java
 dae94c20fbd24f6a11fab8b73e92d18b31a1b97b 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleDeleteGroupsResponse.java
 6d38a096f95b4d0bb2843656d05d17483b45c86c 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleDeleteUsersRequest.java
 79010d539189399cc850b7537478d29d5a9753e8 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleDeleteUsersResponse.java
 93d49b3250d6cbfaa8affb4425ebb8efb1bf9741 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleGrantPrivilegeRequest.java
 e9e0e634495ff1e6103fa6a101df0d5cfd150aa2 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleGrantPrivilegeResponse.java
 fbb13af562510314599a0a09a83a60fa2d4f910e 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleRevokePrivilegeRequest.java
 a4d89604da5e9e6d0680a670642933ee31a98305 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleRevokePrivilegeResponse.java
 8a730ea69783b1f898ac5b99352a6953b6026f7a 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TCreateSentryRoleRequest.java
 4aff2ebd2e540e37eee5cd03240e930f3c748ae5 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TCreateSentryRoleResponse.java
 929ac22c2e11af76b564cb0f78ccc162fbb9cbe1 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TDropPrivilegesRequest.java
 b007b249f7d7f920792c674d68c7cd4d30d63aa0 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TDropPrivilegesResponse.java
 d756c0a414156f87e6804c7317e6201065f66ffe 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TDropSentryRoleRequest.java
 55272ac625deac1085179ee432eb922463668305 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TDropSentryRoleResponse.java
 69e3e62f9f93216823d2af3faedb02a2ba5a7190 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TListSentryPrivilegesByAuthRequest.java
 b371478a30b25c2500e5b944d8205abde09a2ab1 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TListSentryPrivilegesByAuthResponse.java
 cebc1f11e0ad9cf5912df40318b4e591772f26c6 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TListSentryPrivilegesForProviderRequest.java
 6e1163d997b4df323232379932f2c527cff4182f 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TListSentryPrivilegesForProviderResponse.java
 1ac780a0855e5a6a92195a37e4619d59e185676e 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TListSentryPrivilegesRequest.java
 a778f254618e2c8fe1b8fc75bc9b19686735f281 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TListSentryPrivilegesResponse.java
 ca4256f9016abea16076d1582e7aea69c56f93eb 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TListSentryRolesForUserRequest.java
 a83231a9cf1a7cb25d1ae851b3531b5fbcb831fc 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TListSentryRolesRequest.java
 5b90861cbf08f3d82462b38ef1e0b03ad1c5c4c9 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TListSentryRolesResponse.java
 dedbd83c2b29aa54ca6de2f73b74e0982cb2082e 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TRenamePrivilegesRequest.java
 04f07b87e6594bdd73ae223f0aaf877d40d00287 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TRenamePrivilegesResponse.java
 6776a773dd229f79d8f88621f4f283a2d476867f 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryActiveRoleSet.java
 2f44a81e90a663e37601d73d857e9db044ac9187 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryAuthorizable.java
 f27a3557ad5d1fe4ec09f0d7b0d1b64084124181 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryConfigValueRequest.java
 2cdd68007db642e91df90ac4c12430186fbc3742 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryConfigValueResponse.java
 7a9cd1ee25f98bf247b3c3bbbf05b96eff9136a7 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryExportMappingDataRequest.java
 2a5321105e7fb4c5c06d739264c73784272ab6c6 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryExportMappingDataResponse.java
 e97de1f794129468079cddeae382efc3a1822b08 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryGroup.java
 bdfd1835984b1fcf93c4fbb65e92540df32abbc6 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryImportMappingDataRequest.java
 db1d9dd415a9af7dcb3ddf4aedea857b3fb514dd 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryImportMappingDataResponse.java
 94d0de6104aa10bbd412d016b3732cdef1683a67 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryMappingData.java
 532b2309548bd54cb3cc647201ae4a0fcaf6c08d 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryPrivilege.java
 6338e8ab3c19f12dcc9807eb3f2e2acec8728bd6 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryPrivilegeMap.java
 e11b581efe6058bfccaa369c2869912ca8f8fd19 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryRole.java
 bed050ecda2adf6416d8d36c75bda020279e8b4f 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentrySyncIDRequest.java
 18d48becd261779a7b95e393be7b7b7f9d4ae8c9 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentrySyncIDResponse.java
 89dcbfff6e6358499508038f56b859c5df481740 
  
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/service/thrift/TSentryResponseStatus.java
 3478bc495d932b7b7e5747adb0d92a89eab89da9 


Diff: https://reviews.apache.org/r/66360/diff/1/


Testing
-------

Made sure all the tests pssed.


Thanks,

kalyan kumar kalvagadda

Reply via email to