----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66480/#review200653 -----------------------------------------------------------
Advertising
sentry-abac/notes.txt Lines 23 (patched) <https://reviews.apache.org/r/66480/#comment281479> Remove this. sentry-abac/src/main/java/org/apache/sentry/abac/Attribute.java Lines 27 (patched) <https://reviews.apache.org/r/66480/#comment281480> Remove navigator mentions. sentry-abac/src/main/java/org/apache/sentry/abac/StaticAttributeProvider.java Lines 81 (patched) <https://reviews.apache.org/r/66480/#comment281474> Deal with the different exception cases here. File exists but not correct permissions. sentry-abac/src/main/java/org/apache/sentry/abac/StaticAttributeProvider.java Lines 82 (patched) <https://reviews.apache.org/r/66480/#comment281475> Again convert to FileUtils read into string. sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestAttributeMap.java Lines 331 (patched) <https://reviews.apache.org/r/66480/#comment281476> Add if exists? sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestAttributeMap.java Lines 333 (patched) <https://reviews.apache.org/r/66480/#comment281477> Again convert to FileUtils. sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestAttributeMap.java Lines 362 (patched) <https://reviews.apache.org/r/66480/#comment281472> Use logger sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestAttributeMap.java Lines 371 (patched) <https://reviews.apache.org/r/66480/#comment281470> Convert to FileUtils. readFileToString sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestAttributeMap.java Lines 377 (patched) <https://reviews.apache.org/r/66480/#comment281471> Conver to logger.info/debug sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestStaticProvider.java Lines 69 (patched) <https://reviews.apache.org/r/66480/#comment281478> File Utils - Steve Moist On April 5, 2018, 9:20 p.m., Liam Sargent wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66480/ > ----------------------------------------------------------- > > (Updated April 5, 2018, 9:20 p.m.) > > > Review request for sentry, Na Li, Steve Moist, and Sergio Pena. > > > Bugs: SENTRY-2189 > https://issues.apache.org/jira/browse/SENTRY-2189 > > > Repository: sentry > > > Description > ------- > > - Example configuration file: example-definition.json > - Attribute: plain old java object for string attribute. > - Object: plain old java object for fully qualified sentry object. > - AttributeMap: Bidirectional map type for quick lookup between Attribute -> > Object, Object -> Attribute. > - AttributeMapAdapter: JSON deserializer for file-based attribute ingestion. > > > Diffs > ----- > > pom.xml 61e0f970017aa8ddf38a59c7c1334fadb97abe40 > sentry-abac/example-definition.json PRE-CREATION > sentry-abac/example-delta.json PRE-CREATION > sentry-abac/notes.txt PRE-CREATION > sentry-abac/pom.xml PRE-CREATION > sentry-abac/src/main/java/org/apache/sentry/abac/Attribute.java > PRE-CREATION > sentry-abac/src/main/java/org/apache/sentry/abac/AttributeMap.java > PRE-CREATION > sentry-abac/src/main/java/org/apache/sentry/abac/AttributeMapAdapter.java > PRE-CREATION > > sentry-abac/src/main/java/org/apache/sentry/abac/AttributeMapKeyException.java > PRE-CREATION > > sentry-abac/src/main/java/org/apache/sentry/abac/GenericAttributeProvider.java > PRE-CREATION > sentry-abac/src/main/java/org/apache/sentry/abac/SentryObject.java > PRE-CREATION > > sentry-abac/src/main/java/org/apache/sentry/abac/StaticAttributeProvider.java > PRE-CREATION > sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestAttribute.java > PRE-CREATION > > sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestAttributeMap.java > PRE-CREATION > > sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestStaticProvider.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/66480/diff/1/ > > > Testing > ------- > > - Unittests for all useful functions. > > > Thanks, > > Liam Sargent > >
