> On April 25, 2018, 8:21 p.m., Sergio Pena wrote: > > Lina, would it be better to create another patch to fix the 2.1.0 versions? > > So we can have this patch to add the index only instead of several new > > files, what do you think? > > Na Li wrote: > Sergio, I don't want to take the trouble to fix the 2.1.0 versions. > However, 2.0 is already released, any schema change on top of that has to > mark it as for version 2.1.0. Is that correct? > > Sergio Pena wrote: > It's correct, but it would be easier to identify what changes for > indexing are made here. If someone wants to backport this change, there will > be conflicts because most of the changes are not ncessary except the index > changes.
the version change is in sentry-2213. It is committed. This only only deals with adding index - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66764/#review201960 ----------------------------------------------------------- On April 27, 2018, 3:13 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66764/ > ----------------------------------------------------------- > > (Updated April 27, 2018, 3:13 p.m.) > > > Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > add index for the foreign key AUTHZ_OBJ_ID on table AUTHZ_PATH > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.derby.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.mysql.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.oracle.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.postgres.sql > PRE-CREATION > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.1.0.sql > ca20a39 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.1.0.sql > 70acb89 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.1.0.sql > eb175bd > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.1.0.sql > e6dbf91 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.1.0.sql > 989301b > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-2.0.0-to-2.1.0.sql > aca05bc > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-2.0.0-to-2.1.0.sql > a3c87bd > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-2.0.0-to-2.1.0.sql > cce5c7c > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-2.0.0-to-2.1.0.sql > 169cd4d > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-2.0.0-to-2.1.0.sql > 986389b > > > Diff: https://reviews.apache.org/r/66764/diff/4/ > > > Testing > ------- > > run mysql script to verify it works on mysql > SentrySchemaTool upgrade/install tests > > > Thanks, > > Na Li > >
