-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66837/
-----------------------------------------------------------
(Updated May 2, 2018, 7:15 p.m.)
Review request for sentry, Na Li and Sergio Pena.
Changes
-------
addressed review comments from sergio.
Bugs: SENTRY-2170
https://issues.apache.org/jira/browse/SENTRY-2170
Repository: sentry
Description
-------
Thrift interface between sentry server and hdfs sentry client should be updated
to send privileges granted to users.
Jira: https://issues.apache.org/jira/browse/SENTRY-2170
Summary of the changes.
This patch includes following changes
enum TPrivilegeEntityType
{ ROLE, USER, HMS_OBJECT_NAME }
New Definitions
struct TPrivilegeEntity {
# Type of the privilege entity
1: required TPrivilegeEntityType type;
# Value of entity
2: required string value;
}
struct TPrivilegeChanges {
The authorizable object that needs to be updated.
1: required string authzObj;
The privileges that needs to be added to
the authorizable object.
2: required map<TPrivilegeEntity, string> addPrivileges;
The privileges that needs to be deleted to
the authorizable object.
3: required map<TPrivilegeEntity, string> delPrivileges;
}
Diffs (updated)
-----
sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPrivilegeChanges.java
dea21fa
sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPrivilegeEntity.java
PRE-CREATION
sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPrivilegeEntityType.java
PRE-CREATION
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/PermissionsUpdate.java
0272396
sentry-hdfs/sentry-hdfs-common/src/main/resources/sentry_hdfs_service.thrift
465b421
sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestPermissionUpdate.java
11d3a2a
sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/UpdateableAuthzPermissions.java
1505513
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PermImageRetriever.java
53ce34f
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java
8485ca3
sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestSentryHDFSServiceProcessor.java
578757e
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/NotificationProcessor.java
96fe413
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/PermissionsImage.java
6c74e19
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
8ac3c0d
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
b410027
Diff: https://reviews.apache.org/r/66837/diff/2/
Changes: https://reviews.apache.org/r/66837/diff/1-2/
Testing
-------
Made sure that all the existing tests pass.
Thanks,
kalyan kumar kalvagadda
