> On May 8, 2018, 4:24 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.1.0.sql > > Line 238 (original), 238 (patched) > > <https://reviews.apache.org/r/66972/diff/2/?file=2017944#file2017944line238> > > > > This script is executed on a fresh installation only, so there > > shouldn't be a problem of an existing index because the table does not > > exist yet. I think we do not need this here.
this change is reverted. - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66972/#review202656 ----------------------------------------------------------- On May 8, 2018, 6:07 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66972/ > ----------------------------------------------------------- > > (Updated May 8, 2018, 6:07 p.m.) > > > Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and > Sergio Pena. > > > Bugs: sentry-2219 > https://issues.apache.org/jira/browse/sentry-2219 > > > Repository: sentry > > > Description > ------- > > Create index only when it does not exist for Oracle DB > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.oracle.sql > 3fa60bb > > > Diff: https://reviews.apache.org/r/66972/diff/3/ > > > Testing > ------- > > Run the script on Oracle DB > > > Thanks, > > Na Li > >
