> On May 9, 2018, 12:13 a.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java > > Lines 40 (patched) > > <https://reviews.apache.org/r/66265/diff/2/?file=2018218#file2018218line40> > > > > Shouldn't this comment be 'set of privileges granted to this user'?
changed > On May 9, 2018, 12:13 a.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java > > Lines 41 (patched) > > <https://reviews.apache.org/r/66265/diff/2/?file=2018218#file2018218line41> > > > > This should be initialized in the constructor like MSentryRole does. changed > On May 9, 2018, 12:13 a.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java > > Lines 106 (patched) > > <https://reviews.apache.org/r/66265/diff/2/?file=2018218#file2018218line106> > > > > Should this comment be MSentryUser? changed > On May 9, 2018, 12:13 a.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java > > Line 76 (original), 116 (patched) > > <https://reviews.apache.org/r/66265/diff/2/?file=2018218#file2018218line116> > > > > Should we include the privileges=[..] word here like the > > MSentryRole.toString() does? changed. - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66265/#review202717 ----------------------------------------------------------- On May 9, 2018, 4:25 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66265/ > ----------------------------------------------------------- > > (Updated May 9, 2018, 4:25 p.m.) > > > Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > Update application code and package.jdo to add mapping between user and > privileges > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryGMPrivilege.java > 0e8fb06 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java > 73fa4ff > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java > f468a46 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > 9ce9cae > > > Diff: https://reviews.apache.org/r/66265/diff/3/ > > > Testing > ------- > > build succeeds. tested working on private build > > > Thanks, > > Na Li > >
