> On May 11, 2018, 4:29 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 2529 (original), 2529 (patched) > > <https://reviews.apache.org/r/67087/diff/1/?file=2019946#file2019946line2529> > > > > Can you use bulk fetch to get all privileges and corresponding users > > and roles? similar to approach in SENTRY-2184? > > > > So the fetching time can be reduced significently and reduce load to > > DB. It is especially important when DB server is far from sentry server.
Lina, That is a general optimization that can be done. Let's not put that change in this jira. This patch current functionality to handle user privileges. I will create another jira for the optimization. - kalyan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67087/#review202950 ----------------------------------------------------------- On May 11, 2018, 12:15 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67087/ > ----------------------------------------------------------- > > (Updated May 11, 2018, 12:15 p.m.) > > > Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena. > > > Bugs: SENTRY-2171 > https://issues.apache.org/jira/browse/SENTRY-2171 > > > Repository: sentry > > > Description > ------- > > When permissions full snapshot is taken by sentry it should include all the > owner privileges added for user and roles. > > Implicit privileges added for the users should be added as user privileges in > the full snapshot. > > Here are the changes needed. > > PermissionsImage should now hold permissions to users > Translate the "OWNER" permission granted to role/user to appropriate > permission > Create PermissionsUpdate with the translated permissions. > > > Diffs > ----- > > > sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/AccessConstants.java > a8e8bb1543041d356767818d25d7c7cb32cd909b > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 458117020b5204187268a4d9742d00e7fe3925d3 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 679a097678dcaaf51d3ddf69360729212546432e > > > Diff: https://reviews.apache.org/r/67087/diff/1/ > > > Testing > ------- > > Made sure all the exiistig tests passed. Also added new test to verify the > change made. > > > Thanks, > > kalyan kumar kalvagadda > >
