----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/#review203319 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/QueryParamBuilder.java Lines 303 (patched) <https://reviews.apache.org/r/67174/#comment285425> Please do not add undocumented public methods. Do you really need this? Can callers decide which method to call instead - they can call either addUsersFilter or addRolesFilter. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 373 (patched) <https://reviews.apache.org/r/67174/#comment285426> Is there a value in retrying this? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 375 (patched) <https://reviews.apache.org/r/67174/#comment285427> Can you use lambda-style instead similar to the way other methods do it? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 796 (patched) <https://reviews.apache.org/r/67174/#comment285430> First sentence should end with a dot. This talks about doing something to the entity's privileges, but there is no entity parameter - which one is the entity? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 798 (patched) <https://reviews.apache.org/r/67174/#comment285431> typo: input. Are existing privileges just removed or replaced with ALL? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 803 (patched) <https://reviews.apache.org/r/67174/#comment285432> This is a predicate, so probably it should be called isSomething... sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 812 (patched) <https://reviews.apache.org/r/67174/#comment285434> you can use ```Sets.newHashSet("a", "b", "c")``` sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 819 (patched) <https://reviews.apache.org/r/67174/#comment285435> It is better to have preconditions check upfront - there is no need to do extra work if preconditions fail. You can also put @NotNull annotation - it will document not null requirements and enable automatic checking. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 858 (patched) <https://reviews.apache.org/r/67174/#comment285436> It may be easier to read if you modify the if statement above: ```if (...) { return true; } // handle the more complicated case ``` - Alexander Kolbasov On May 17, 2018, 1:28 a.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67174/ > ----------------------------------------------------------- > > (Updated May 17, 2018, 1:28 a.m.) > > > Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar > kalvagadda, and Sergio Pena. > > > Bugs: sentry-2156 > https://issues.apache.org/jira/browse/sentry-2156 > > > Repository: sentry > > > Description > ------- > > Add functions related to grant/revoke privileges to/from user > > Fix the bugs related to grant/revoke partial privileges. They are caused by > adding fine grained privileges (CRATE, DROP, ALTER) > add test cases for grant/revoke privileges to/from user > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/service/common/ServiceConstants.java > 71e9585 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > 816cfe1 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/QueryParamBuilder.java > 8a77fc1 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > cafe2b5 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 0322cc3 > > > Diff: https://reviews.apache.org/r/67174/diff/2/ > > > Testing > ------- > > all test cases in TestSentryStore passed > > > Thanks, > > Na Li > >
