-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67093/#review203363
-----------------------------------------------------------



Can't we tease apart that database models and possibly JPA layer stuff back 
into sentry-provider-db then have sentry-service-server depend on that?


sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/NotificationProcessor.java
Line 201 (original), 202 (patched)
<https://reviews.apache.org/r/67093/#comment285533>

    Convert back to EventType.valueOf.  It's more clear.



sentry-service/sentry-service-client/pom.xml
Lines 62 (patched)
<https://reviews.apache.org/r/67093/#comment285531>

    Nit: Too many empty lines, remove.



sentry-service/sentry-service-server/pom.xml
Lines 113 (patched)
<https://reviews.apache.org/r/67093/#comment285532>

    Why is this commented out, why not just remove it?


- Steve Moist


On May 15, 2018, 6:47 p.m., Anthony Young-Garner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67093/
> -----------------------------------------------------------
> 
> (Updated May 15, 2018, 6:47 p.m.)
> 
> 
> Review request for sentry.
> 
> 
> Bugs: SENTRY-2208
>     https://issues.apache.org/jira/browse/SENTRY-2208
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Refactored the SentryService class and its dependencies from 
> sentry-provider/sentry-provider-db into a new 
> sentry-service/sentry-service-server module. In addition, refactored 
> SentryServiceClientFactory into a new sentry-service/sentry-service-client 
> module.
> 
> Work is based on previously completed work on SENTRY-1205.
> 
> NOTE: The diff looks large, but the overwhelming majority (9 pages) of the 
> diff consists of file moves (from sentry-provider-db to sentry-service-server)
> 
> https://issues.apache.org/jira/browse/SENTRY-2208
> 
> 
> Diffs
> -----
> 
>   sentry-hdfs/sentry-hdfs-service/pom.xml 
> 50a451d917eb7428cd71ab7cedd9c4363111c166 
>   sentry-provider/sentry-provider-db/pom.xml 
> 48a187ae54afd435c1f3d4aa57b0d696cd634fbe 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessor.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessorFactory.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryHealthCheckServletContextListener.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryMetricsServletContextListener.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessorFactory.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SentryPolicyStorePlugin.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeObject.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java
>  876ee146ab31aaa82b83e88585c45bb2deabc0d2 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/GenericPrivilegeConverter.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/TSentryPrivilegeConverter.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/appender/AuditLoggerTestAppender.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/appender/RollingFileWithoutDeleteAppender.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/AuditMetadataLogEntity.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/DBAuditMetadataLogEntity.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/GMAuditMetadataLogEntity.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntity.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntityFactory.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsSnapshotId.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MPath.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryChange.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryGMPrivilege.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryGroup.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryHmsNotification.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPathChange.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUtil.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryVersion.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/CounterWait.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/DeltaTransactionBlock.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/FixedJsonInstanceSerializer.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HMSFollower.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/LeaderStatusMonitor.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/NotificationProcessor.java
>  228d37c6f226fe94fc243fe9b6ec95feb696e4bd 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/PathsImage.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/PermissionsImage.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/QueryParamBuilder.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
>  cafe2b5975df3cd692c733159352bbb0e49bd387 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreSchemaInfo.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/TransactionBlock.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/TransactionManager.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/FullUpdateModifier.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/GSSCallback.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSClient.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollowerState.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveConnectionFactory.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveSimpleConnectionFactory.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/JaasConfiguration.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/KerberosConfiguration.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ProcessorFactory.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryKerberosContext.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientFactory.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceFactory.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceState.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryState.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryStateBank.java
>   
>   sentry-provider/sentry-provider-db/src/main/webapp/SentryService.html  
>   
> sentry-provider/sentry-provider-db/src/main/webapp/css/bootstrap-theme.min.css
>   
>   sentry-provider/sentry-provider-db/src/main/webapp/css/bootstrap.min.css  
>   sentry-provider/sentry-provider-db/src/main/webapp/css/sentry.css  
>   sentry-provider/sentry-provider-db/src/main/webapp/sentry.png  
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/generic/thrift/SentryGenericServiceIntegrationBase.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/generic/thrift/TestAuditLogForSentryGenericService.java
>  dea6152fd8226229a0aa5dd8b26cda10fc6bdc5b 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/generic/thrift/TestSentryGenericPolicyProcessor.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/generic/thrift/TestSentryGenericServiceClient.java
>  2f72e88f3946e46b085b5bba05a8ac46ca0f178e 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/generic/thrift/TestSentryGenericServiceIntegration.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/service/thrift/SentryMiniKdcTestcase.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/service/thrift/TestAuthorizingDDLAuditLogWithKerberos.java
>  fb412415a6bc3a82847b3cb5700fa4945ec0ac2f 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/service/thrift/TestConnectionWithTicketTimeout.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/service/thrift/TestNotificationHandlerInvoker.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyServiceClient.java
>  e84593692cabde013694a9565c8ac7869ce09423 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyStoreProcessor.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServerForPoolWithoutKerberos.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServerLogLevel.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServerPubSub.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServerWithoutKerberos.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServiceClientPool.java
>  6c88955a56adaeca54edf8d68678f624c77a7698 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServiceFailureCase.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServiceForPoolWithKerberos.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServiceImportExport.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServiceIntegration.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServiceMetrics.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServiceWithInvalidMsgSize.java
>  8ac63080f5770538bbe537aa61dbee15aab35f26 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServiceWithKerberos.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/service/thrift/TestSentryWebServerWithKerberos.java
>  3cc9a9d1826eebc48e4ebf269b1eb7447c2921a4 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/service/thrift/TestSentryWebServerWithSSL.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/service/thrift/TestSentryWebServerWithoutSecurity.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreIntegrationBase.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestDelegateSentryStore.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestPrivilegeOperatePersistence.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestSentryGMPrivilege.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestSentryRole.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/appender/TestRollingFileWithoutDeleteAppender.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestDbAuditMetadataLogEntity.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestGMAuditMetadataLogEntity.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestJsonLogEntityFactory.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestJsonLogEntityFactoryGM.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/util/TestCommandUtil.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/model/TestMSentryUtil.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestCounterWait.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollower.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollowerSentryStoreIntegration.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestLeaderStatusMonitor.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestNotificationProcessor.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryPrivilege.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreImportExport.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreToAuthorizable.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryVersion.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java
>  7e5e91dd84e806f2b35009298c3396ab3f632001 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryStateBankTestHelper.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryWebMetricParser.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestFullUpdateInitializer.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestFullUpdateModifier.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHiveNotificationFetcher.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestSentryHMSClient.java
>   
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestSentryStateBank.java
>   
>   sentry-service/pom.xml 0388476f2e55dbc76262a4b0ddb597b816d8fb15 
>   sentry-service/sentry-service-client/pom.xml PRE-CREATION 
>   sentry-service/sentry-service-server/pom.xml PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/001-SENTRY-327.derby.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/001-SENTRY-327.mysql.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/001-SENTRY-327.oracle.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/001-SENTRY-327.postgres.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/002-SENTRY-339.derby.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/002-SENTRY-339.mysql.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/002-SENTRY-339.oracle.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/002-SENTRY-339.postgres.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/003-SENTRY-380.derby.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/003-SENTRY-380.mysql.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/003-SENTRY-380.oracle.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/003-SENTRY-380.postgres.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/004-SENTRY-74.derby.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/004-SENTRY-74.mysql.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/004-SENTRY-74.oracle.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/004-SENTRY-74.postgres.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/005-SENTRY-398.derby.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/005-SENTRY-398.mysql.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/005-SENTRY-398.oracle.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/005-SENTRY-398.postgres.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/006-SENTRY-711.derby.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/006-SENTRY-711.mysql.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/006-SENTRY-711.oracle.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/006-SENTRY-711.postgres.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/007-SENTRY-1365.derby.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/007-SENTRY-1365.mysql.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/007-SENTRY-1365.oracle.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/007-SENTRY-1365.postgres.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/008-SENTRY-1569.derby.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/008-SENTRY-1569.mysql.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/008-SENTRY-1569.oracle.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/008-SENTRY-1569.postgres.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/009-SENTRY-1805.derby.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/009-SENTRY-1805.mysql.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/009-SENTRY-1805.oracle.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/009-SENTRY-1805.postgres.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/010-SENTRY-2210.derby.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/010-SENTRY-2210.mysql.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/010-SENTRY-2210.oracle.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/010-SENTRY-2210.postgres.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-db2-1.4.0.sql 
> PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-db2-1.5.0.sql 
> PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-db2-1.6.0.sql 
> PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-db2-1.7.0.sql 
> PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-db2-1.8.0.sql 
> PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-db2-2.0.0.sql 
> PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-db2-2.1.0.sql 
> PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-derby-1.4.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-derby-1.5.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-derby-1.6.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-derby-1.7.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-derby-1.8.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-derby-2.0.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-derby-2.1.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-mysql-1.4.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-mysql-1.5.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-mysql-1.6.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-mysql-1.7.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-mysql-1.8.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-mysql-2.0.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-mysql-2.1.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-oracle-1.4.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-oracle-1.5.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-oracle-1.6.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-oracle-1.7.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-oracle-1.8.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-oracle-2.0.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-oracle-2.1.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-postgres-1.4.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-postgres-1.5.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-postgres-1.6.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-postgres-1.7.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-postgres-1.8.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-postgres-2.0.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-postgres-2.1.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-db2-1.4.0-to-1.5.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-db2-1.5.0-to-1.6.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-db2-1.6.0-to-1.7.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-db2-1.8.0-to-2.0.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-db2-2.0.0-to-2.1.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-derby-1.4.0-to-1.5.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-derby-1.5.0-to-1.6.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-derby-1.6.0-to-1.7.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-derby-1.8.0-to-2.0.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-derby-2.0.0-to-2.1.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-mysql-1.4.0-to-1.5.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-mysql-1.5.0-to-1.6.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-mysql-1.6.0-to-1.7.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-mysql-1.8.0-to-2.0.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-mysql-2.0.0-to-2.1.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-oracle-1.4.0-to-1.5.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-oracle-1.5.0-to-1.6.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-oracle-1.6.0-to-1.7.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-oracle-1.8.0-to-2.0.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-oracle-2.0.0-to-2.1.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-postgres-1.4.0-to-1.5.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-postgres-1.5.0-to-1.6.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-postgres-1.6.0-to-1.7.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-postgres-1.8.0-to-2.0.0.sql
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/sentry-upgrade-postgres-2.0.0-to-2.1.0.sql
>  PRE-CREATION 
>   sentry-service/sentry-service-server/src/main/resources/upgrade.order.db2 
> PRE-CREATION 
>   sentry-service/sentry-service-server/src/main/resources/upgrade.order.derby 
> PRE-CREATION 
>   sentry-service/sentry-service-server/src/main/resources/upgrade.order.mysql 
> PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/upgrade.order.oracle 
> PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/resources/upgrade.order.postgres
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryWebServiceForAuthTypeNone.java
>  3d8bf960267c86c57e0acf9aa7572bf8aff67735 
>   sentry-service/sentry-service-server/src/test/resources/cacerts.jks 
> PRE-CREATION 
>   sentry-service/sentry-service-server/src/test/resources/keystore.jks 
> PRE-CREATION 
>   sentry-service/sentry-service-server/src/test/resources/log4j.properties 
> PRE-CREATION 
>   sentry-tests/sentry-tests-hive/pom.xml 
> 6816249da67a3fe9d0bc97217c5d8e8e184788a0 
>   sentry-tests/sentry-tests-kafka/pom.xml 
> e61f64db0c6787d09874235d061061add1b746d0 
>   sentry-tests/sentry-tests-solr/pom.xml 
> d9540a61f7394e3e316e8bd367c3d30aa7e66f14 
>   sentry-tests/sentry-tests-sqoop/pom.xml 
> eed8269d4e1b67fd622d539741e50d9984ae90c8 
>   sentry-tools/pom.xml b882c6f60dd0e3f33309e8e24ba1cab04fb7d86c 
> 
> 
> Diff: https://reviews.apache.org/r/67093/diff/4/
> 
> 
> Testing
> -------
> 
> mvn clean install
> 
> 
> Thanks,
> 
> Anthony Young-Garner
> 
>

Reply via email to