> On May 18, 2018, 1:30 p.m., kalyan kumar kalvagadda wrote: > > General question? Who is authorized to perform this operation? Is it just > > admin? Is it tested?
Yes just admin for now. There is an upstream jira to allow non-admins to run but that needs to be coded. I'll add an explicit test case for it > On May 18, 2018, 1:30 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java > > Line 192 (original), 201-213 (patched) > > <https://reviews.apache.org/r/67134/diff/2/?file=2024691#file2024691line201> > > > > Why is it sepeate written in if else and not part of the switch > > statement below. We can put it in the same switch statement but will have many if conditions later on. The purpose of the change was to not touch pre-existing code base too much > On May 18, 2018, 1:30 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java > > Lines 208 (patched) > > <https://reviews.apache.org/r/67134/diff/2/?file=2024691#file2024691line208> > > > > why are you using PrincipalType.USER? I am using USER as default. There is a Hive ticket I created that has a type UNKNOWN to match with HivePrincipal.HivePrincipalType but thats in code review. For now USER is default > On May 18, 2018, 1:30 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java > > Line 302 (original), 327-331 (patched) > > <https://reviews.apache.org/r/67134/diff/2/?file=2024691#file2024691line329> > > > > This change is to support show grant for database? Looks to me a > > unrelated change. You should either change the title OR submit in seperate > > jira. Ok will submit a separate JIRA for it > On May 18, 2018, 1:30 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > > Lines 210 (patched) > > <https://reviews.apache.org/r/67134/diff/2/?file=2024692#file2024692line210> > > > > Why do you need to pass principle here when you know that it is empty > > and when you doesn't expect it? Good point will remove it > On May 18, 2018, 1:30 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > > Lines 299 (patched) > > <https://reviews.apache.org/r/67134/diff/2/?file=2024692#file2024692line300> > > > > error message is wrong. Thanks. Will fix it - Arjun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67134/#review203413 ----------------------------------------------------------- On May 17, 2018, 4:46 a.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67134/ > ----------------------------------------------------------- > > (Updated May 17, 2018, 4:46 a.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, Steve Moist, and > Sergio Pena. > > > Repository: sentry > > > Description > ------- > > Currently Sentry doesn't support Hive command to show privileges on > authorizables without mentioning any role or user name > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/hadoop/hive/ql/exec/SentryHivePrivilegeObjectDesc.java > 4fa4221b4 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java > 23246c903 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > fc2427cbf > > sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java > 2e3fd7f36 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > cafe2b597 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestShowGrants.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/67134/diff/2/ > > > Testing > ------- > > $ mvn -f sentry-binding/pom.xml test > $ mvn -f sentry-provider/pom.xml test > > > Thanks, > > Arjun Mishra > >
