----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67325/#review203906 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java Lines 1267 (patched) <https://reviews.apache.org/r/67325/#comment286284> it should be ownerPrivilege.setAction(AccessConstants.OWNER); iF AccessConstants.OWNER IS NOT defined, define it sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyStoreProcessor.java Lines 155 (patched) <https://reviews.apache.org/r/67325/#comment286285> do you need to create another instance of SentryPolicyStoreProcessor? The checking configuration is in each function call. So it can handle dynamic configuration change sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyStoreProcessor.java Lines 164 (patched) <https://reviews.apache.org/r/67325/#comment286287> You need to make sure authorizable.setTable(null); to get create owner privilege for DB. sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyStoreProcessor.java Lines 166 (patched) <https://reviews.apache.org/r/67325/#comment286286> the action should be AccessConstants.OWNER - Na Li On May 25, 2018, 2:28 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67325/ > ----------------------------------------------------------- > > (Updated May 25, 2018, 2:28 p.m.) > > > Review request for sentry, Na Li and Sergio Pena. > > > Bugs: SENTRY-2246 > https://issues.apache.org/jira/browse/SENTRY-2246 > > > Repository: sentry > > > Description > ------- > > Based in the notifications from HMS sentry should construct privilege > (TSentryPrivilege) to grant/revoke privilege from the user. > > > > This Jira is created to have API to construct TSentryPrivilege for a given > authorizable. > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/service/common/ServiceConstants.java > 71e9585d304d8b6391faa83c5df2a3d6ee494bde > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > 816cfe182a9d42ba9b553ab10a149171b28d3727 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyStoreProcessor.java > efacf19ad56f2674c4caaf52d91fb0cee6861552 > > > Diff: https://reviews.apache.org/r/67325/diff/1/ > > > Testing > ------- > > Added unit test to veirfy API. > > > Thanks, > > kalyan kumar kalvagadda > >
