----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67402/#review204152 -----------------------------------------------------------
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Line 818 (original), 841 (patched) <https://reviews.apache.org/r/67402/#comment286541> Should we do the same check and removal from users as well? - Sergio Pena On May 31, 2018, 3:49 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67402/ > ----------------------------------------------------------- > > (Updated May 31, 2018, 3:49 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda and Sergio Pena. > > > Bugs: sentry-2244 > https://issues.apache.org/jira/browse/sentry-2244 > > > Repository: sentry > > > Description > ------- > > When granting privilege to a user or role, sentry does not need to get > individual privilege with specific action from DB again after all its > associated privileges are fetched from DB. We just just find the > corresponding privilege from list to avoid extra query to DB > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 5932335 > > > Diff: https://reviews.apache.org/r/67402/diff/1/ > > > Testing > ------- > > test cases in TestSentryStore succeeded > > > Thanks, > > Na Li > >
