-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67442/#review204326
-----------------------------------------------------------




sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
Lines 1211-1214 (patched)
<https://reviews.apache.org/r/67442/#comment286765>

    Can wemove this to new API so that this logic need not be repeated. 
something like persistUser() where you check if it stale and take appripriate 
action.
    
    I need to add similar code in in my patch where owner privieges are revoked.


- kalyan kumar kalvagadda


On June 4, 2018, 11:07 p.m., Na Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67442/
> -----------------------------------------------------------
> 
> (Updated June 4, 2018, 11:07 p.m.)
> 
> 
> Review request for sentry, kalyan kumar kalvagadda and Sergio Pena.
> 
> 
> Bugs: sentry-2258
>     https://issues.apache.org/jira/browse/sentry-2258
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> remove the user when it does not privilege and role
> 
> 
> Diffs
> -----
> 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
>  5932335 
>   
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
>  e2d24e5 
> 
> 
> Diff: https://reviews.apache.org/r/67442/diff/1/
> 
> 
> Testing
> -------
> 
> TestSentryStorey
> 
> 
> Thanks,
> 
> Na Li
> 
>

Reply via email to