-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67452/
-----------------------------------------------------------

(Updated June 7, 2018, 4:54 p.m.)


Review request for sentry, Na Li and Sergio Pena.


Changes
-------

Addressed review comments.


Bugs: SENTRY-2257
    https://issues.apache.org/jira/browse/SENTRY-2257


Repository: sentry


Description
-------

Implement functionality in sentry store to update owner privilege on an 
authorizable.

Here is the approach.

There are two new API's that are exposed. 

To list the owner privileges granted to an authorizable
1. update the owner privilege to new owner

Here is the Flow.
1. SentryPolicyStoreProcessor would first get the list of privileges that are 
to be revoked.
2. Using the list of privileges that are to be revoked, list of 
PermissionsUpdate is generated using SentryPlug-in
3. SentryPolicyStoreProcessor would then use the new API to update the owner 
privileges.

This way all the updated listed below happen in the same transaction
1. Revoking the exixting owner privilage for authorizable
2. Granting new owner privilege fot authorizable.
3. Adding delta update for owner privilege revoked
4. Adding delta update for owner privilege granted.


Diffs (updated)
-----

  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
 e6b71b5a4a97deafdf955bd70f0ead760e5fdb1a 
  
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
 12c6d916cf449499c1cceb6ddc50e68c88a6606e 


Diff: https://reviews.apache.org/r/67452/diff/5/

Changes: https://reviews.apache.org/r/67452/diff/4-5/


Testing
-------

Added new tests to verify new functionality added.


Thanks,

kalyan kumar kalvagadda

Reply via email to