----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67477/#review204467 -----------------------------------------------------------
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Line 1404 (original), 1121 (patched) <https://reviews.apache.org/r/67477/#comment286951> Can you rebase the code to get ride of such changes? - Na Li On June 6, 2018, 4:15 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67477/ > ----------------------------------------------------------- > > (Updated June 6, 2018, 4:15 p.m.) > > > Review request for sentry, Na Li and Sergio Pena. > > > Bugs: SENTRY-2252 > https://issues.apache.org/jira/browse/SENTRY-2252 > > > Repository: sentry > > > Description > ------- > > Currently there is a lot a code that is duplicated to handle privileges for > user and roles. This code could be made generic. There is no functinal change > becasuse of this patch. As we are adding more and more code aroung user/roles > this change is important so that we don't end having a buch of duplicate > logic spread in number of methods. > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java > 85477b6a8b8470f3005e44d5d7f7f1981135f49b > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java > fb8f5d2f6cdecf8de8d45357ec3f2411fb7b8d43 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java > 9188738fc45d5a658b44404cd5e70d5f553e8d28 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/PrivilegeEntity.java > PRE-CREATION > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 5932335ef9f6e3f894da9a65a4bf1bdedcbe0ffc > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestSentryRole.java > 65d26c0695fd2d27a57e9d997966c540578c5622 > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollowerSentryStoreIntegration.java > 4e8a2e699dd8aa8f4571f1ac8beceada88c4f8a3 > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > e2d24e53d0d3f8a738066cfedc85b11f6535f45c > > > Diff: https://reviews.apache.org/r/67477/diff/1/ > > > Testing > ------- > > Made sure all the existing tests passed. > > > Thanks, > > kalyan kumar kalvagadda > >
