----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67218/#review204545 -----------------------------------------------------------
I noticed that there are test cases for SHOW GRANT ROLE ON DATABASE in TestCrossDbOps. Why do you think it is not supported? sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/hadoop/hive/ql/exec/SentryHivePrivilegeObjectDesc.java Lines 43-45 (original), 44 (patched) <https://reviews.apache.org/r/67218/#comment287099> Is this moved accidentally? sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/hadoop/hive/ql/exec/SentryHivePrivilegeObjectDesc.java Lines 54 (patched) <https://reviews.apache.org/r/67218/#comment287100> Seems all methods has the line as a new line. it would be good to keep the consistency of the code blocks. sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java Lines 302-305 (patched) <https://reviews.apache.org/r/67218/#comment287101> SentryHiveAuthorizationTaskFactoryImpl is not used anymore. DefaultAccessController.showPrivileges() is used instead to return a list of privileges with the SHOW command. Could you remove this class and the Test class in another jira to avoid making changes by mistake? - Sergio Pena On June 11, 2018, 3:56 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67218/ > ----------------------------------------------------------- > > (Updated June 11, 2018, 3:56 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, Steve Moist, and > Sergio Pena. > > > Repository: sentry > > > Description > ------- > > Right now database is not supported with command SHOW GRANT ROLE/USER ON > DATABASE > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/hadoop/hive/ql/exec/SentryHivePrivilegeObjectDesc.java > 4fa4221b4 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java > 23246c903 > > sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java > 2e3fd7f36 > > > Diff: https://reviews.apache.org/r/67218/diff/1/ > > > Testing > ------- > > mvn -f sentry-binding/pom.xml test > > > Thanks, > > Arjun Mishra > >
