----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67134/#review204955 -----------------------------------------------------------
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java Lines 295 (patched) <https://reviews.apache.org/r/67134/#comment287793> Space 'since authorizable ' must be ' since authorizable ' so it is displayed correctly. sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java Lines 323 (patched) <https://reviews.apache.org/r/67134/#comment287794> This should variable is not only for roles, isn't it? the privilegeMap may have users as well. Is it better to change the name to just privilegesMap? sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java Lines 328 (patched) <https://reviews.apache.org/r/67134/#comment287795> Users are also retrieved by the caller, why are we handling only roles? sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryObjectPrivileges.java Lines 22 (patched) <https://reviews.apache.org/r/67134/#comment287796> Write a javadoc comment about what this class does. Same thing for the public methods. sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryObjectPrivileges.java Lines 25-26 (patched) <https://reviews.apache.org/r/67134/#comment287798> Make a space line here. sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryObjectPrivileges.java Lines 27-28 (patched) <https://reviews.apache.org/r/67134/#comment287797> Assing the values only if the response is not null. sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClient.java Line 243 (original), 258 (patched) <https://reviews.apache.org/r/67134/#comment287799> Why is the users parameter removed? It is part of the 'grant role to user' functionality. - Sergio Pena On June 18, 2018, 7:08 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67134/ > ----------------------------------------------------------- > > (Updated June 18, 2018, 7:08 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, Steve Moist, and > Sergio Pena. > > > Repository: sentry > > > Description > ------- > > Currently Sentry doesn't support Hive command to show privileges on > authorizables without mentioning any role or user name > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java > 23246c903 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > f0b4b4466 > > sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java > 2e3fd7f36 > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryObjectPrivileges.java > PRE-CREATION > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClient.java > 6f38ed20d > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java > 45dce0e7c > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestShowGrants.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/67134/diff/9/ > > > Testing > ------- > > $ mvn -f sentry-binding/pom.xml test > $ mvn -f sentry-provider/pom.xml test > > > Thanks, > > Arjun Mishra > >
