----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67637/#review205009 -----------------------------------------------------------
Ship it! Looks good. - kalyan kumar kalvagadda On June 18, 2018, 10:40 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67637/ > ----------------------------------------------------------- > > (Updated June 18, 2018, 10:40 p.m.) > > > Review request for sentry and kalyan kumar kalvagadda. > > > Bugs: sentry-2265 > https://issues.apache.org/jira/browse/sentry-2265 > > > Repository: sentry > > > Description > ------- > > Adds the OWNER action in the HiveActionFactory class which sets the OWNER > action identical to the ALL action. > This will ensure that the action checks behave like the ALL privilege. > > > Diffs > ----- > > > sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/HiveActionFactory.java > ad7e1c9f2b62c82e4006bcb1ec6bab440ddfac33 > > > Diff: https://reviews.apache.org/r/67637/diff/1/ > > > Testing > ------- > > I cannot test this with unit tests because there are not grant/revoke to > users yet. Unit tests for ownership will be added later once ownership is > granted automatically in Sentry. > However, I did test it in a local cluster manually by modifying the database > directly to add the owner privilege to a user. Then check that the user gets > the correct authorization when the owner privilege is set and even show > tables display only the tables of the owner. > > > Thanks, > > Sergio Pena > >
