> On June 20, 2018, 4:04 p.m., Arjun Mishra wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > > Lines 235 (patched) > > <https://reviews.apache.org/r/67646/diff/1/?file=2042347#file2042347line235> > > > > Should this be a WARN level message?
I don't think we should warn admins that the user does not exist. This log would happen if they run 'show grant user unknown_user'. I feel a warning should be a message to alarm the user of something weird is happening and should be investigated but Sentry can continue without issues. - Sergio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67646/#review205091 ----------------------------------------------------------- On June 19, 2018, 3:25 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67646/ > ----------------------------------------------------------- > > (Updated June 19, 2018, 3:25 p.m.) > > > Review request for sentry, Arjun Mishra and kalyan kumar kalvagadda. > > > Bugs: sentry-2272 > https://issues.apache.org/jira/browse/sentry-2272 > > > Repository: sentry > > > Description > ------- > > This patch catches the NoSuchObject Exception on the Sentry Hive binding when > the SHOW GRANT USER is executed, and it returns an empty list of privileges > for the requested user so that Hive does not display a nasty error message on > the console. > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > 321701d8662364f0a48899c1d8d5c75cc2ce62ff > > > Diff: https://reviews.apache.org/r/67646/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >
