----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67691/#review205201 -----------------------------------------------------------
Ship it! Looks Good. - kalyan kumar kalvagadda On June 21, 2018, 2:41 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67691/ > ----------------------------------------------------------- > > (Updated June 21, 2018, 2:41 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > In SentryHdfsMetricsUtil.java, the Timer "getDeltaPermChangesTimes" and the > Histogram "getDeltaPermChangesHistogram" are using the > PathDeltaRetriever.class. Shouldn't this be the PermDeltaRetreiver.class? > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHdfsMetricsUtil.java > 03ccb444f > > > Diff: https://reviews.apache.org/r/67691/diff/1/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >
