> On June 21, 2018, 10:16 p.m., kalyan kumar kalvagadda wrote: > > Arjun, > > > > Can you explian what was wrong with old test case?
The test case has been changeed to include a new role, role2, and a new uri privilege granted to this role. If we were to set active role set as both role1 and role2, and set say authorizable to uri1, the old code would've broken the test as it would've returned 2 results (both URI privileges). assertTrue(privileges.size() == 1) would be FALSE. This is becuse it wasn't using the other condition check to compare URIs - Arjun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67695/#review205212 ----------------------------------------------------------- On June 21, 2018, 9:18 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67695/ > ----------------------------------------------------------- > > (Updated June 21, 2018, 9:18 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > This is a follow up to SENTRY-2231 to add test cases to validate > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 51048bc29 > > > Diff: https://reviews.apache.org/r/67695/diff/1/ > > > Testing > ------- > > $ mvn -f sentry-service/sentry-service-server/pom.xml test > -Dtest=TestSentryStore > > > Thanks, > > Arjun Mishra > >
