> On June 26, 2018, 4:37 p.m., Na Li wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestShowGrants.java > > Lines 235 (patched) > > <https://reviews.apache.org/r/67745/diff/2/?file=2045134#file2045134line235> > > > > why do you leave the code commented? The test should verify that > > command retrives the result
There should be another ticket that addresses this. Basically user privileges are not being created when a create database command is executed. Because of this the show grant user command will fail - Arjun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67745/#review205379 ----------------------------------------------------------- On June 26, 2018, 4:25 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67745/ > ----------------------------------------------------------- > > (Updated June 26, 2018, 4:25 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > The SentryHiveAuthorizationTaskFactoryImpl class creates all the supported > DDL tasks for authorization in Hive. We need to add the support for the SHOW > GRANT USER as well. > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java > 660bef115 > > sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java > 8b6b223da > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestShowGrants.java > 500b38b0c > > > Diff: https://reviews.apache.org/r/67745/diff/2/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >
