----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67759/#review205453 -----------------------------------------------------------
sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClient.java Lines 312 (patched) <https://reviews.apache.org/r/67759/#comment288372> Also we can return TSentryPrivilegeMap as opposed to this. TSentryPrivilegeMap has the map of name to set of privileges - Arjun Mishra On June 27, 2018, 4:49 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67759/ > ----------------------------------------------------------- > > (Updated June 27, 2018, 4:49 p.m.) > > > Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li. > > > Bugs: sentry-2284 > https://issues.apache.org/jira/browse/sentry-2284 > > > Repository: sentry > > > Description > ------- > > Add two API methods to the Sentry client: > - listAllRolesPrivileges > - listAllUsersPrivileges > > Both methods return a map object of the form: > - [roleName, set<privileges>] > - [userName, set<privileges>] > > Unit tests, thrift API code and Client methods are provided. > > > Diffs > ----- > > > sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/SentryPolicyService.java > d456d7ff64a8146473ff14a65f06e7cb664939b7 > > sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryPrivilegesRequest.java > PRE-CREATION > > sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryPrivilegesResponse.java > PRE-CREATION > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClient.java > dc1d67ba16c9c7acf76eb3318864ba0606e2aa5a > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java > 5f76cb0aa3bd17d6aca4adc52ba59ded5ec0b900 > > sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift > 56aedcb5267495e610e3dace1f38e708d68ffe84 > > sentry-service/sentry-service-api/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyServiceClientDefaultImpl.java > 1666e326462b771674930e52e3790ca92f467778 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > 39271500df179e0ddf8ce4f1589eaaa8137afa25 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > d8ab1fc90255c6ed42c00e3d3aa6103e47a40b29 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreInterface.java > f61ae575c99474a76886d3c7a74765fdb067acd6 > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyStoreProcessor.java > de4e0012d521cf402f4773a04b673f8056a5337c > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 52ce72cebc8b69f08988b05ba54e2bbedd201c1a > > > Diff: https://reviews.apache.org/r/67759/diff/2/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >
