----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67790/ -----------------------------------------------------------
Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li. Bugs: sentry-2294 https://issues.apache.org/jira/browse/sentry-2294 Repository: sentry Description ------- Added the new parameter 'requestorUserName' that passes the user name making the notifyHmsEvent call. The hive binding uses the same HMS user name to make this request. Sentry can use this requestor to print it in the logs and perhaps to use it as a the grantor when granting the owner privilege. Also, I made some refactoring in the parameter list of the notifyHmsEvent call move the thrift request object on the client and not on the caller. Diffs ----- sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryHmsEvent.java 60f17b0eee8e7955a9daf929e008ecd962217860 sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java 7e3419b32d1c411d825de8a956f308d17b6c015e sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/metastore/TestSentrySyncHMSNotificationsPostEventListener.java 6a09e6729043e60b135dc60e3e6ff28db6cd09d9 sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryHmsEventNotification.java 2252a5954fc668cb2d5bd750491730523bfc71d4 sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClient.java 6137fa8b362b3b7e79226ae6cee2c230a53e867f sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java 74e358f3f77879835c3b7378acbeff1dda5d6497 sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift 8d55f39f4625b900e39de0558971b225e6192c85 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java e7d81edcb68539c5ab6a4ea39c76f1a7448c9db4 Diff: https://reviews.apache.org/r/67790/diff/1/ Testing ------- Thanks, Sergio Pena