----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67807/#review205664 -----------------------------------------------------------
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java Lines 993 (patched) <https://reviews.apache.org/r/67807/#comment288550> Maybe keep the name consitent with isAdminGroup() so isAdminUser() sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java Lines 1523 (patched) <https://reviews.apache.org/r/67807/#comment288555> Should this be request.getAuthorizable()? Because that translates to server,db,tbl so on. The parameters should be switched sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java Lines 1617 (patched) <https://reviews.apache.org/r/67807/#comment288556> Same as above. The parameter should be switched - Arjun Mishra On July 3, 2018, 11:51 a.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67807/ > ----------------------------------------------------------- > > (Updated July 3, 2018, 11:51 a.m.) > > > Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena. > > > Bugs: SENTRY-2295 > https://issues.apache.org/jira/browse/SENTRY-2295 > > > Repository: sentry > > > Description > ------- > > There are two cases that should be considered. > > When an admin user is created a database or table, owner privilege should not > be added. > When the ownership is transferred to an admin user, existing owner privilege > should be revoked but new one should not be added. > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > 95ae15d614740747c7196dddb1e8303472a7289b > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 004f06d138e5829fc72c1d66d07aa9988ff1a5d3 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreInterface.java > 19c29725a2354d23652e4905ee694f7f8ea3f7f7 > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyStoreProcessor.java > c8051e356e5f44f8d3ef69432b886ef26de13f67 > > > Diff: https://reviews.apache.org/r/67807/diff/1/ > > > Testing > ------- > > Updated unit tests to verify the same > > > Thanks, > > kalyan kumar kalvagadda > >
