----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67879/#review206417 -----------------------------------------------------------
Fix it, then Ship it! Please address the comment. sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java Lines 304-312 (patched) <https://reviews.apache.org/r/67879/#comment289360> I don't recommend this log message. Logging the names of databases, tables and partition names may not be good idea as that could be huge information. Let's handle the logging for FullUpdateInitializer.java seperate jira. Let's use the jir SENTRY-2301 for it. - kalyan kumar kalvagadda On July 20, 2018, 3:44 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67879/ > ----------------------------------------------------------- > > (Updated July 20, 2018, 3:44 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena. > > > Bugs: SENTRY-2309 > https://issues.apache.org/jira/browse/SENTRY-2309 > > > Repository: sentry > > > Description > ------- > > Adding to std.out will allow full snapshot timeline messages like has fetch > started, or has fetch been persisted, to be separated out from the rest of > the logs and be identified more easily > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationInfo.java > 61b0d10ca > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > 065adb74f > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/common/SentryServiceUtil.java > 719e616bf > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/HMSFollower.java > 7667c47d5 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java > 992d8ab52 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java > 12266cb25 > > > Diff: https://reviews.apache.org/r/67879/diff/9/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >
