----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68226/ -----------------------------------------------------------
Review request for sentry, Na Li, Steve Moist, and Sergio Pena. Bugs: SENTRY-2320 https://issues.apache.org/jira/browse/SENTRY-2320 Repository: sentry Description ------- Update of existing Sentry CLIs to use jcommander dependency rather than commons-cli in order to provider for a more full featured base on which to build new Sentry commands, in particular the proposed commands for Attribute Based Column Masking (see SENTRY-2227). Diffs ----- sentry-tools/pom.xml 05cd75c9c96b7940b759423f3c27a4bb0657001d sentry-tools/src/main/java/org/apache/sentry/cli/tools/PermissionsMigrationToolCommon.java bf108f4cc1d7b8949f562418e428750abf580961 sentry-tools/src/main/java/org/apache/sentry/cli/tools/SentryConfigToolCommon.java 2d4f9737062be33a224a6d25762b264b0314f710 sentry-tools/src/main/java/org/apache/sentry/cli/tools/SentryConfigToolIndexer.java 896e8530bc1311a452aeecb92a41bf4a0fa38749 sentry-tools/src/main/java/org/apache/sentry/cli/tools/SentrySchemaTool.java 4c3df208de9a5d4f973061579e629b2b39f2162e sentry-tools/src/main/java/org/apache/sentry/cli/tools/SentryShellCommon.java 94800a4c512384e68de25d021fbb10c13d24ef7d sentry-tools/src/main/java/org/apache/sentry/cli/tools/SentryShellIndexer.java 95ae0b4ecf447f847b00ef8a49e50c9e6f64a157 sentry-tools/src/test/java/org/apache/sentry/cli/tools/TestPermissionsMigrationToolSolr.java 9001a535629644946c75260ab0ec1ecd5e656ff9 sentry-tools/src/test/java/org/apache/sentry/cli/tools/TestSentryShellIndexer.java 082987df25dea8c68afb1e97f8ea032e05374475 sentry-tools/src/test/java/org/apache/sentry/cli/tools/TestSentryShellKafka.java 9a7b6f9c24e0f555a927a1fe4971edd0b1dc9aee sentry-tools/src/test/java/org/apache/sentry/cli/tools/TestSentryShellSolr.java b583e1b8233961e02476df11bc67b71e7fa20a34 sentry-tools/src/test/java/org/apache/sentry/cli/tools/TestSentryShellSqoop.java 1a0e0a1229773e2e6226eb388efa1f0f0c3a82ef Diff: https://reviews.apache.org/r/68226/diff/1/ Testing ------- mvn clean install (with particular focus on passage of existing CLI usage tests). Thanks, Anthony Young-Garner