> On Aug. 23, 2018, 8:54 p.m., Alexander Kolbasov wrote: > > sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java > > Lines 27 (patched) > > <https://reviews.apache.org/r/68488/diff/2/?file=2076865#file2076865line27> > > > > What is this file - where does it come from?
Derived from the Keycloak SPI Implementaion (https://github.com/keycloak/keycloak/blob/4.3.0.Final/services/src/main/java/org/keycloak/provider/DefaultProviderLoader.java) which is under an Apache 2.0 License with author attribution left in place. > On Aug. 23, 2018, 8:54 p.m., Alexander Kolbasov wrote: > > sentry-spi/src/main/java/org/apache/sentry/spi/Provider.java > > Lines 23 (patched) > > <https://reviews.apache.org/r/68488/diff/2/?file=2076866#file2076866line23> > > > > Where does this file come from? Derived from the Keycloak SPI Implementaion (https://github.com/keycloak/keycloak/blob/4.3.0.Final/server-spi/src/main/java/org/keycloak/provider/Provider.java) which is under an Apache 2.0 License with author attribution left in place. > On Aug. 23, 2018, 8:54 p.m., Alexander Kolbasov wrote: > > sentry-spi/src/main/java/org/apache/sentry/spi/ProviderFactory.java > > Lines 25 (patched) > > <https://reviews.apache.org/r/68488/diff/2/?file=2076867#file2076867line25> > > > > where ddoes this file come from? Derived from the Keycloak SPI Implementaion (https://github.com/keycloak/keycloak/blob/4.3.0.Final/server-spi/src/main/java/org/keycloak/provider/ProviderFactory.java) which is under an Apache 2.0 License with author attribution left in place. > On Aug. 23, 2018, 8:54 p.m., Alexander Kolbasov wrote: > > sentry-spi/src/main/java/org/apache/sentry/spi/ProviderManager.java > > Lines 34 (patched) > > <https://reviews.apache.org/r/68488/diff/2/?file=2076869#file2076869line34> > > > > Typo? "Provider manager *what*" Yeah typo. will clean up - Brian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68488/#review207847 ----------------------------------------------------------- On Aug. 23, 2018, 8:15 p.m., Brian Towles wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68488/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2018, 8:15 p.m.) > > > Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na > Li, Steve Moist, and Sergio Pena. > > > Bugs: SENTRY-2367 > https://issues.apache.org/jira/browse/SENTRY-2367 > > > Repository: sentry > > > Description > ------- > > Basic implementation of the Java SPI. Abstracted to provide Factory > configuration for > instances of Service defined. > > Currently stand alone module. Will be built used by MDCM in future commits. > > > Diffs > ----- > > lombok.config PRE-CREATION > pom.xml dcf107680c3b395819043136bcc6e179a60ada35 > sentry-spi/pom.xml PRE-CREATION > sentry-spi/src/main/java/org/apache/sentry/spi/DefaultProviderLoader.java > PRE-CREATION > sentry-spi/src/main/java/org/apache/sentry/spi/Provider.java PRE-CREATION > sentry-spi/src/main/java/org/apache/sentry/spi/ProviderFactory.java > PRE-CREATION > sentry-spi/src/main/java/org/apache/sentry/spi/ProviderLoader.java > PRE-CREATION > sentry-spi/src/main/java/org/apache/sentry/spi/ProviderManager.java > PRE-CREATION > sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java PRE-CREATION > sentry-spi/src/main/java/org/apache/sentry/spi/package-info.java > PRE-CREATION > sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProvider.java > PRE-CREATION > sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderFactory.java > PRE-CREATION > sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplA.java > PRE-CREATION > sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplB.java > PRE-CREATION > > sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestProviderImplNotLoaded.java > PRE-CREATION > sentry-spi/src/test/java/org/apache/sentry/spi/SomeTestSpi.java > PRE-CREATION > sentry-spi/src/test/java/org/apache/sentry/spi/TestProviderManager.java > PRE-CREATION > > sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.SomeTestProviderFactory > PRE-CREATION > sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.Spi > PRE-CREATION > > > Diff: https://reviews.apache.org/r/68488/diff/2/ > > > Testing > ------- > > Unit tests. > > > Thanks, > > Brian Towles > >
