----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68716/#review208706 -----------------------------------------------------------
Ship it! Ship It! - Sergio Pena On Sept. 14, 2018, 1:22 p.m., Peter Somogyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68716/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2018, 1:22 p.m.) > > > Review request for sentry. > > > Bugs: SENTRY-2403 > https://issues.apache.org/jira/browse/SENTRY-2403 > > > Repository: sentry > > > Description > ------- > > RollingFileWithoutDeleteAppender incorrectly append timestamp to logfiles > without removing previous one. > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/log/appender/RollingFileWithoutDeleteAppender.java > fd133f34f > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/log/appender/TestRollingFileWithoutDeleteAppender.java > ca9062bca > > > Diff: https://reviews.apache.org/r/68716/diff/1/ > > > Testing > ------- > > Modified TestRollingFileWithoutDeleteAppender to check the pattern correctly. > > > Thanks, > > Peter Somogyi > >
