> On Sept. 20, 2018, 2:20 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > > Lines 288-300 (patched) > > <https://reviews.apache.org/r/68779/diff/1/?file=2090406#file2090406line288> > > > > Is it possible to reuse the extractDatabase() and extractTable() > > commands that already does most of this split of db and table names?
extractDatabase() and extractTable() are deprecated, and we should not use them any more. I found we can use extractDbTableNameFromTOKTABLE(), which sets output DB and table. So I need to change alterTableSetOwnerPrivilege in HiveAuthzPrivilegesMap to use output db and table instead of input. In this way, it is more consistent with alterDbSetOwnerPrivilege, which also uses output db. - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68779/#review208796 ----------------------------------------------------------- On Sept. 20, 2018, 4:24 a.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68779/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2018, 4:24 a.m.) > > > Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio > Pena. > > > Bugs: sentry-2409 > https://issues.apache.org/jira/browse/sentry-2409 > > > Repository: sentry > > > Description > ------- > > add code to get table name and DB name based on token children size > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > 6731d1a > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java > 55a79ee > > > Diff: https://reviews.apache.org/r/68779/diff/1/ > > > Testing > ------- > > unit tests in TestOwnerPrivileges passed > > > Thanks, > > Na Li > >
