Stephen, I prefer option 2), so our code can be more consistent.
Thanks, Lina On Tue, Sep 25, 2018 at 11:30 AM Stephen Moist <mo...@cloudera.com.invalid> wrote: > Hey all, with Sentry-2374, we’ve introduced Lombok to create our loggers > in the SPI portion of Sentry. For consistency’s sake, we should migrate > the existing Sentry code to use the Lombok annotations instead of using the > existing logger.getLogger(class). I see 2 ways of doing it. 1) As classes > are modified, add in the annotation and remove the existing logger. 2) > Create an epic in Jira, create tasks under it for each maven module, then > go through all the classes in each module and convert to it. > > I don’t think this is critical or time sensitive to do, but it should be > more of a code cleanup task than anything else that we can do over the next > few months. Thoughts on this?
