----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68822/#review209007 -----------------------------------------------------------
sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift Lines 419 (patched) <https://reviews.apache.org/r/68822/#comment293272> I heard today that it is possible to assign user to a role in near future. So can you change the function name to "list_sentry_privileges_by_user_and_itsroles"? it will cover privileges 1) assigned to user directly 2) assigned to roles directly associated to a user 3) assigned to roles directly associated to groups that user belongs to. Then when that feature of allowing user to be associated to a role is implemented, we don't need to change this API. And the intention of this function is to get all privileges for a user directly and indirectly sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreInterface.java Lines 247 (patched) <https://reviews.apache.org/r/68822/#comment293273> Can you change the name of this function to "listSentryPrivilegesByUsersAndRoles" to be consistent with client API function name? - Na Li On Sept. 25, 2018, 9:23 p.m., Hao Hao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68822/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2018, 9:23 p.m.) > > > Review request for sentry, Na Li and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > This commit adds a new thrift API list_sentry_privileges_for_user to List > sentry privileges granted to the given user and the group the user associated > with, filterted based on authorization hierarchy if present. > Under the hood, this API is using sentryStore.listSentryPrivilegesForProvider. > > > Diffs > ----- > > > sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/SentryPolicyService.java > 0cbd8ab0a624d4c09aead4097f72762e12d1d21b > > sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift > 2e79e5646ae9102d8c0c28da4260a539254fcd15 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java > 236a07bdf5191cdc0f167f20a406b721b3dc506d > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > 3a9623b46f7c4335db18113574170f761da9a4ca > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 1eda41b2b6bd940a404cc1ba09a861fe783ead04 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreInterface.java > 0b4f4aa24bd3002c50bf4d80a6fa361f66052973 > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > d8c0ab4fa82ba09c60bc995eb4f53a78a7fae346 > > > Diff: https://reviews.apache.org/r/68822/diff/3/ > > > Testing > ------- > > Unit test. > > > Thanks, > > Hao Hao > >
