-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68823/#review209564
-----------------------------------------------------------




sentry-service/sentry-service-server/src/test/java/org/apache/sentry/service/thrift/TestFullUpdateInitializer.java
Lines 261 (patched)
<https://reviews.apache.org/r/68823/#comment294091>

    should you check if the number of db, tables and partitions are fetched?


- Na Li


On Sept. 24, 2018, 3:03 a.m., Sergio Pena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68823/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2018, 3:03 a.m.)
> 
> 
> Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li.
> 
> 
> Bugs: sentry-2416
>     https://issues.apache.org/jira/browse/sentry-2416
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Resets the FullUpdateInitializer metrics counters to zero if another snapshot 
> process starts. This will help to track how many objects are being requested 
> from HMS.
> 
> 
> Diffs
> -----
> 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java
>  3e27d1bbee9bea9a60e7f7e012a367957610826c 
>   
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/service/thrift/TestFullUpdateInitializer.java
>  589acbed12855ff09309a04c9214f8daf87ea1de 
> 
> 
> Diff: https://reviews.apache.org/r/68823/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>

Reply via email to